Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Oct 4, 2024

Reason for Change:

Logs and records IPAM metrics on Request/Release and MarkPendingRelease calls.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from a team as code owners October 4, 2024 22:34
@rbtr rbtr added the cns Related to CNS. label Oct 4, 2024
@rbtr rbtr self-assigned this Oct 4, 2024
@rbtr rbtr force-pushed the feat/log-ip-states branch 2 times, most recently from ca644f0 to a07cd62 Compare October 14, 2024 20:17
@rbtr rbtr requested a review from timraymond October 15, 2024 01:04
@rbtr rbtr force-pushed the feat/log-ip-states branch 2 times, most recently from 08dfec5 to d00a6af Compare October 15, 2024 19:26
@github-actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Oct 30, 2024
@thatmattlong thatmattlong removed the stale Stale due to inactivity. label Oct 30, 2024
@rbtr rbtr requested a review from timraymond November 5, 2024 16:44
@rbtr rbtr force-pushed the feat/log-ip-states branch from d00a6af to 1d6c4b4 Compare November 5, 2024 16:48
@rbtr
Copy link
Collaborator Author

rbtr commented Nov 5, 2024

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr enabled auto-merge November 5, 2024 16:48
@rbtr rbtr added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 3c4641c Nov 6, 2024
14 checks passed
@rbtr rbtr deleted the feat/log-ip-states branch November 6, 2024 01:37
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
)

* feat: add IPConfig state logs/metrics to Request/Release handlers

Signed-off-by: Evan BaKer <[email protected]>

* make metrics recording async so that it will not block ip requests

Signed-off-by: Evan Baker <[email protected]>

---------

Signed-off-by: Evan BaKer <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants